Skip to content

Bug 2021787 - Rate limiting is failing on Github ETL when retrieving pull request data from mozilla-conduit/lando repository#11

Merged
dklawren merged 4 commits intomainfrom
2021787
Mar 10, 2026
Merged

Bug 2021787 - Rate limiting is failing on Github ETL when retrieving pull request data from mozilla-conduit/lando repository#11
dklawren merged 4 commits intomainfrom
2021787

Conversation

@dklawren
Copy link
Contributor

@dklawren dklawren commented Mar 8, 2026

No description provided.

…pull request data from mozilla-conduit/lando repository
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix GitHub API rate-limit handling in the ETL when extracting pull request–related data (notably for mozilla-conduit/lando) by centralizing retry logic and improving the sleep behavior around rate-limit reset.

Changes:

  • Replaced repeated per-call rate-limit handling blocks with a shared github_get() helper.
  • Updated sleep_for_rate_limit() to sleep with a small buffer past the reset time.
  • Updated PR/commit/reviewer/comment extraction to use github_get().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@dklawren dklawren requested a review from cgsheeh March 8, 2026 21:40
Copy link
Member

@cgsheeh cgsheeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. 👍

@dklawren dklawren merged commit 11e09ca into main Mar 10, 2026
4 checks passed
@dklawren dklawren deleted the 2021787 branch March 10, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants